potiuk commented on code in PR #36611: URL: https://github.com/apache/airflow/pull/36611#discussion_r1442801474
########## docs/apache-airflow/howto/docker-compose/index.rst: ########## @@ -149,7 +149,7 @@ On **all operating systems**, you need to run database migrations and create the .. code-block:: bash - docker compose up airflow-init + docker compose run airflow-init Review Comment: I am not against changing it to run. It quite matches the purpose of run vs. up as described in https://docs.docker.com/compose/faq/#whats-the-difference-between-up-run-and-start But I think you'd ne need to investigate why `up` does not work for you. It should. Can you explain HOW it does not work for you? What happens? However `run` has some properties that are different than `up` - for example it will leave the container behind when you use run, so generally you should also use `--rm` flag if you want to use run becaause (unlike up) it will create a new container every time you run it , where `up` will use the same project as the main project you use when you start other services in it. Also any change here should be acompanied by updating our tests. We are running `docker compose` quick start tests in our CI https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L1929C34-L1929C34 and thanks to that both me and @Taragolis believe that it works - because it passes the tests (and that's why we are asking you why it does not work for you and what problems does it solve). Maybe there is a good reason it does not work for your Windows 11 desktop and it would be good if you could investigate why. And yes - maybe the conclusion is that it should be changed to use `run` but if we do, then this PR should also add similar step to our docker-compose tests to make sure that what we have in our docs is also tested in our CI., -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
