aritra24 commented on code in PR #36692:
URL: https://github.com/apache/airflow/pull/36692#discussion_r1447056664
##########
airflow/models/connection.py:
##########
@@ -140,6 +140,7 @@ def __init__(
if self.password:
mask_secret(self.password)
+ mask_secret(quote(self.password))
Review Comment:
We quote the password in the get uri method,
[here](https://github.com/apache/airflow/blob/main/airflow/models/connection.py#L257)
this will convert a password like "s3cr3t!" into "s3cr3t%21" converting the
special chars into encoded chars. So when these parameters are accessed they
don't get masked because they differ from the unquoted chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
