hussein-awala commented on PR #36692:
URL: https://github.com/apache/airflow/pull/36692#issuecomment-1890789664
> @hussein-awala I see the test failing on main
>
> ```
> =========================== short test summary info
============================
> FAILED
tests/always/test_connection.py::TestConnection::test_masking_from_db -
AssertionError: assert equals failed
> [
> call('s3cr3t!'),
> call('s3cr3t%21'),
> [call('s3cr3t!'), call({'apikey call({'apikey': 'masked too'}
> ': 'masked too'})] ),
> ]
> ======================= 1 failed, 13 warnings in 20.21s
========================
> ```
That's because you check if the mock is called with quote method, which is
not currently the case.
Could you add a test that checks if the final result is correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
