m1racoli commented on PR #36849: URL: https://github.com/apache/airflow/pull/36849#issuecomment-1900201327
> @m1racoli would you mind summarizing, assuming this PR is accepted, what else needs to be done on this topic? It just that this problem had several issues opened for it and several PRs were raised to address it (with different approaches) both in Airflow and in upstream gcloud-aio. So it's a bit hard to track which PR replaces another PR, which one is a workaround till another PR is merged and what should be the next steps First of all, this PR would make #36341 redundant. Furthermore it will remove the need for https://github.com/talkiq/gcloud-aio/pull/665. The proposed feature in gcloud-aio only adds the capability to define impersonation for gcloud-aio tokens and clients. It would still require the Airflow provider to make use of this capability by passing the corresponding values. And the Airflow provider currently depends on gcloud-aio-auth version 4, while the new feature would land in version 5. Thus we also would need to upgrade the gcloud-aio dependencies. Something which is certainly achievable, but also adds risk and uncertainty. On the other hand this PR allows us to rely on already existing functionality of the GCP hook for generating a credentials object from a GCP connection (including impersonated credentials and therefore providing support for impersonation chain on hook or connection level). Thus we avoid the need for additional work to support those and future features by only focusing on the task for generating an access token from a given credentials object asynchronously. Therefore I believe this approach should be the approach going forward for using gcloud-aio clients, as we have removed the dependency on gcloud-aio-auth capabilities. This PR is expected to immediately resolve any issues around lack of support of impersonation chain with gcloud-aio based deferrable tasks as long the corresponding hooks and triggers are being instantiated correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
