m1racoli commented on code in PR #36849:
URL: https://github.com/apache/airflow/pull/36849#discussion_r1463062271
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -639,6 +689,7 @@ async def get_sync_hook(self) -> Any:
self._sync_hook = await
sync_to_async(self.sync_hook_class)(**self._hook_kwargs)
return self._sync_hook
- async def service_file_as_context(self) -> Any:
Review Comment:
You are right! I only checked the use of this method within the airflow
repo, but indeed it's public.
I can keep it in. Doesn't necessarily need to be deprecated though.
In this context I will also make CredentialsToken non-public, to avoid
issues in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
