Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1463345865


##########
airflow/jobs/job.py:
##########
@@ -213,9 +218,12 @@ def heartbeat(
                 session.merge(self)
                 self.latest_heartbeat = timezone.utcnow()
                 session.commit()
+                # After committing verify if heartbeat has recovered after 
crossing health check threshold

Review Comment:
   I am resolving this conversation for now @Lee-W. if you have any specific 
test recommendation that fits this case, please let me know. I will add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to