Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1464523088
##########
airflow/jobs/job.py:
##########
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
- def is_alive(self, grace_multiplier=2.1) -> bool:
+ @cached_property
Review Comment:
@amoghrajesh this function is already covered in the unit test. the right
function for adding the unit test would be heartbeat(). Let me check that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
