potiuk commented on code in PR #37050:
URL: https://github.com/apache/airflow/pull/37050#discussion_r1468798592
##########
.pre-commit-config.yaml:
##########
@@ -18,7 +18,7 @@
default_stages: [commit, push]
default_language_version:
python: python3
- node: 18.6.0
+ node: 21.6.1
Review Comment:
For example pyproject.toml ones:
```
requires = [
"editables==0.5",
"gitdb==4.0.11",
"gitpython==3.1.40",
"hatchling==1.21.0",
"packaging==23.2",
"pathspec==0.12.1",
"pluggy==1.3.0",
"smmap==5.0.1",
"tomli==2.0.1; python_version < '3.11'",
"trove-classifiers==2023.11.29",
]
```
They should be be fixed in pyproject.toml (because we want to maintain
build-reproducibility and our users being able to install airflow from sdist in
the future, regardless of new version) - but we also want to upgrade them
regularly (so failing canary build when new version is released seems like a
good idea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
