Taragolis commented on code in PR #37050:
URL: https://github.com/apache/airflow/pull/37050#discussion_r1468801621


##########
.pre-commit-config.yaml:
##########
@@ -18,7 +18,7 @@
 default_stages: [commit, push]
 default_language_version:
   python: python3
-  node: 18.6.0
+  node: 21.6.1

Review Comment:
   The problem with `node` it has very aggressive policy when it comes to old 
(but still supported) OS. In the past some contributors have a problem when 
they use not latest version of OS because they basically can't install node 18 
into the Centos 7 or Amazon Linux 2 due to old version of glibc.
   
   My assumption that switch to node 21 doesn't have any side affect to the 
maintainers who use MacOS, Arch Linux, latest non-LTS Ubuntu and any other 
rolling-release Linux distributions, however it might affect others, or might 
not. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to