Don-Burns opened a new pull request, #37150:
URL: https://github.com/apache/airflow/pull/37150
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #37089
related: #37089
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
# Summary
As documented in #37089 the SQLThresholdCheckOperator will currently fail if
a "falsey" value is returned from the query (e.g. 0 or "").
This is a fix to change the error check a bit and as side effect make the
exception for `The following query returned zero rows:...`
Whereas before, if no rows really were returned, the user would see the
following:
```
result = hook.get_first(self.sql)[0]
TypeError: 'NoneType' object is not subscriptable
```
For testing, I used a parameterized test on an existing test and added a new
test to cover the "no rows returned" case.
But please let me know if something else would be preferable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
