Don-Burns commented on code in PR #37150:
URL: https://github.com/apache/airflow/pull/37150#discussion_r1476905912
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -1058,9 +1058,13 @@ def __init__(
def execute(self, context: Context):
hook = self.get_db_hook()
- result = hook.get_first(self.sql)[0]
- if not result:
+ result = hook.get_first(self.sql)
+
+ # if the query returns 0 rows result will be None so cannot be indexed
into
+ if result is None:
Review Comment:
Yes, that would do it in case the DB fetch changes to be able to return a
collection in the future.
Empty str could be a false raise of this error but since the operator should
only be dealing with numerics that should be ok. I will make the change along
these lines then 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
