VladaZakharova commented on PR #37072: URL: https://github.com/apache/airflow/pull/37072#issuecomment-1929625614
Hi @raphaelauv ! As i have checked the KubernetesCreateResourceOperator is not using any specific hook method to call create_from_yaml() from kubernetes client. The logic that we actually need in GKEStartKueueInsideClusterOperator covers more then just this, as i have mentioned before: checking is the cluster accepts installing Kueue inside, waiting for the yaml to be applied on the Cluster method and also outputting errors if there are such. I am not sure that instantiating from KubernetesCreateResourceOperator only for one specific call [method](https://github.com/VladaZakharova/airflow/blob/7c52afd5e4b249f9b89f1caf9d1fb5a1a02a832f/airflow/providers/cncf/kubernetes/operators/resource.py#L117) is the way how we want it to be. I will still suggest having this logic in separate operator with its own logic. KubernetesCreateResourceOperator is a great parent class for the operators i am working on now: GKECreateClusterQueueOperator and GKECreateLocalQueueOperator. The plan is to use the logic from KubernetesCreateResourceOperator to pass YAML file and run it in cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
