VladaZakharova commented on PR #37072:
URL: https://github.com/apache/airflow/pull/37072#issuecomment-1941186088

   > ```
   > Based on this documentation for 
[Kueue](https://kueue.sigs.k8s.io/docs/installation/) the conditions to meet 
before we actually can install Kueue are different from the conditions for 
installing Kueue inside GKE cluster
   > ```
   > 
   > I do not see any reference to GKE in this doc and anything that explicit 
that deploy Kueue in GKE is different than deploy Kueue to a "normal" K8S
   
   If you will take a look on the document i have added regarding installation 
of Kueue inside 
[GKE](https://cloud.google.com/kubernetes-engine/docs/tutorials/kueue-intro#create_a_cluster)
 you will see that conditions for GKE are different from conditions for general 
K8s cluster.  GKEStartKueueInsideClusterOperator was designed specifically to 
cover GKE clusters and all the checks were added to check needed conditions. 
   For K8s clusters, as you can see, we have different workflow and the only 
similar part between installation for GKE and K8s is actually installing Kueue 
using k8s api call create_from_yaml(). So to follow your request and create 
base class in Kubernetes to then inherit from it in GKE, i will add 2 different 
operators which will use only 1 common api call - call create_from_yaml().


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to