Taragolis commented on code in PR #37202:
URL: https://github.com/apache/airflow/pull/37202#discussion_r1480102784
##########
airflow/providers/apprise/hooks/apprise.py:
##########
@@ -48,7 +48,7 @@ def __init__(self, apprise_conn_id: str = default_conn_name)
-> None:
def get_config_from_conn(self):
conn = self.get_connection(self.apprise_conn_id)
- return json.loads(conn.extra_dejson["config"])
+ return conn.extra_dejson["config"]
Review Comment:
This would be a breaking changes, what if we keep previous behaviour, e.g.
if `conn.extra_dejson["config"]` is string than try to `json.loads` and raise a
warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]