infohash commented on code in PR #37202:
URL: https://github.com/apache/airflow/pull/37202#discussion_r1480125669


##########
airflow/providers/apprise/hooks/apprise.py:
##########
@@ -48,7 +48,7 @@ def __init__(self, apprise_conn_id: str = default_conn_name) 
-> None:
 
     def get_config_from_conn(self):
         conn = self.get_connection(self.apprise_conn_id)
-        return json.loads(conn.extra_dejson["config"])
+        return conn.extra_dejson["config"]

Review Comment:
   In think the change is too small to warn the user. It's better to keep both 
behaviour like this:
   
   ```python
   config = conn.extra_dejson["config"]
   return config if isinstance(config, dict) else json.loads(config)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to