Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1485549912


##########
airflow/providers/pinecone/provider.yaml:
##########
@@ -44,7 +44,7 @@ dependencies:
   # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some 
breaking changes.
   # It's crucial to adhere to the v3.0.0 Migration Guide before the 
upper-bound limitation can be removed.
   # 
https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b
-  - pinecone-client>=2.2.4,<3.0
+  - pinecone-client~=3.0.0

Review Comment:
   This would not work as expected, e.g. maximum allowed version would be 3.1 - 
0.0.1
   
   You could check it by use 
[`packaging`](https://packaging.pypa.io/en/stable/index.html) library
   
   ```python
   from packaging.requirements import SpecifierSet
   from packaging.version import Version
   
   
   specifiers = [
       SpecifierSet("~=3.0.0"),
       SpecifierSet("~=3.0"),
       SpecifierSet(">=3,<4"),
   ]
   
   versions = [
       Version("2.2.4"),
       Version("3.0.0"),
       Version("3.0.1"),
       Version("3.1.0"),
       Version("4.0.0"),
   ]
   
   for spec in specifiers:
       print(f" {spec} ".center(72, "="))
       for version in versions:
           print(f"Version {version} in spec? {version in spec}")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to