rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082


##########
airflow/providers/pinecone/provider.yaml:
##########
@@ -44,7 +44,7 @@ dependencies:
   # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some 
breaking changes.
   # It's crucial to adhere to the v3.0.0 Migration Guide before the 
upper-bound limitation can be removed.
   # 
https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b
-  - pinecone-client>=2.2.4,<3.0
+  - pinecone-client~=3.0.0

Review Comment:
   Regarding the pin, I did want to limit >=3.0.0 and <3.1.0. Since, <2 
wouldn't work for us and 3.1 can possibly have breaking changes. Once Pinecone 
releases 3.1, I thought we can test them out and then change pin to 
`pinecone-client>3,<3.2` . Do you think its a reasonable approach? 
   
   
   And thanks for introducing me to `SpecifierSet`. That is new to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to