jedcunningham commented on PR #37480:
URL: https://github.com/apache/airflow/pull/37480#issuecomment-1949358805

   > This is fully backwards compatible, it will ship more metrics than already 
exist and won't change any existing metrics
   
   The chart just remaps, it doesn't exclude metrics that aren't covered. Task 
durations for tasks in task groups already are exposed. This would move them.
   
   e.g.
   
   ```
   
airflow_dag_task_group_example_my_taskgroup_sometask_duration{quantile="0.5"} 
0.17767495400000002
   
airflow_dag_task_group_example_my_taskgroup_sometask_duration{quantile="0.9"} 
0.17767495400000002
   
airflow_dag_task_group_example_my_taskgroup_sometask_duration{quantile="0.99"} 
0.17767495400000002
   airflow_dag_task_group_example_my_taskgroup_sometask_duration_sum 
0.17767495400000002
   airflow_dag_task_group_example_my_taskgroup_sometask_duration_count 1
   ```
   
   Would become:
   
   ```
   
airflow_task_duration{dag_id="task_group_example",task_id="sometask",taskgroup_id="my_taskgroup",quantile="0.5"}
 0.085300168
   
airflow_task_duration{dag_id="task_group_example",task_id="sometask",taskgroup_id="my_taskgroup",quantile="0.9"}
 0.085300168
   
airflow_task_duration{dag_id="task_group_example",task_id="sometask",taskgroup_id="my_taskgroup",quantile="0.99"}
 0.085300168
   
airflow_task_duration_sum{dag_id="task_group_example",task_id="sometask",taskgroup_id="my_taskgroup"}
 0.085300168
   
airflow_task_duration_count{dag_id="task_group_example",task_id="sometask",taskgroup_id="my_taskgroup"}
 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to