jedcunningham commented on code in PR #37480:
URL: https://github.com/apache/airflow/pull/37480#discussion_r1496950583


##########
chart/files/statsd-mappings.yml:
##########
@@ -52,6 +52,13 @@ mappings:
       dag_id: "$1"
       task_id: "$2"
 
+  - match: airflow.dag.*.*.*.duration

Review Comment:
   Another curve ball, guess what? Dags can have dots too :) So imagine we have 
`airflow.dag.first.second.third`. This could be:
   
   - dag_id=first, task_group=second, task_id=third
   - dag_id=first.second, task_id=third (no task_group at all)
   - dag_id=first, task_id=second.third (no task_group at all)
   
   You can also disable the task group id prefixing with 
`prefix_group_id=False`, so those last 2 could actually be in a task group, but 
not one named `second`.
   
   Basically, there isn't a reliable way to extract task group id out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to