Taragolis commented on code in PR #37518:
URL: https://github.com/apache/airflow/pull/37518#discussion_r1493809910
##########
airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook:
GCSHook, s3_hook: S3H
self.defer(
trigger=CloudStorageTransferServiceCreateJobsTrigger(
project_id=gcs_hook.project_id,
+ gcp_conn_id=self.gcp_conn_id,
Review Comment:
One nit here, it possible that end user will use new version of Amazon
provider and old version of Google Provider, in this case it will raise error.
So better pass parameters conditionally, depend on google provider version,
e.g. something like that
https://github.com/apache/airflow/blob/b6499ace635ea36bb690a9a1373e8dddec6151e2/airflow/providers/amazon/aws/transfers/gcs_to_s3.py#L144-L150
It also maybe a good idea to raise a warning in case of old version of
Google Provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
