Taragolis commented on code in PR #37518:
URL: https://github.com/apache/airflow/pull/37518#discussion_r1504722068
##########
airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook:
GCSHook, s3_hook: S3H
self.defer(
trigger=CloudStorageTransferServiceCreateJobsTrigger(
project_id=gcs_hook.project_id,
+ gcp_conn_id=self.gcp_conn_id,
Review Comment:
>or do we need to place this warning elsewhere?
Well, this check should be done into the amazon provider, no reason to check
it into the google.
Because google always returns True in condition `Version(__version__) >=
Version("10.15.0")` and amazon should know which parameter should be propagated
and which ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
