rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1496742109


##########
airflow/providers/pinecone/hooks/pinecone.py:
##########
@@ -135,118 +132,98 @@ def upsert(
         )
 
     @staticmethod
+    def get_pod_spec_obj(environment, replicas, shards, pods, pod_type, 
metadata_config, source_collection):
+        return PodSpec(
+            environment=environment,
+            replicas=replicas,
+            shards=shards,
+            pods=pods,
+            pod_type=pod_type,
+            metadata_config=metadata_config,
+            source_collection=source_collection,
+        )
+
+    @staticmethod
+    def get_serverless_spec_obj(cloud, region):
+        return ServerlessSpec(cloud=cloud, region=region)
+
     def create_index(
+        self,
         index_name: str,
         dimension: int,
-        index_type: str | None = "approximated",
+        spec: ServerlessSpec | PodSpec,
         metric: str | None = "cosine",
-        replicas: int | None = 1,
-        shards: int | None = 1,
-        pods: int | None = 1,
-        pod_type: str | None = "p1",
-        index_config: dict[str, str] | None = None,
-        metadata_config: dict[str, str] | None = None,
-        source_collection: str | None = "",

Review Comment:
   Yes, I will include them in the changelog. will request for a feedback once 
I am done. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to