Dev-iL commented on code in PR #37575: URL: https://github.com/apache/airflow/pull/37575#discussion_r1497145333
########## tests/serialization/serializers/test_serializers.py: ########## @@ -26,19 +27,22 @@ import pytest from dateutil.tz import tzutc from deltalake import DeltaTable +from packaging.version import Version from pendulum import DateTime from pendulum.tz.timezone import FixedTimezone, Timezone -from airflow import PY39 from airflow.models.param import Param, ParamsDict from airflow.serialization.serde import DATA, deserialize, serialize -if PY39: +if sys.version_info >= (3, 9): Review Comment: The python version check is unnecessary for `importlib.metadata`. I know this because my own changes, that don't include this guard, passed the tests (that ran among else on py 3.8, as far as I can tell) and got merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org