Dev-iL commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497308622


##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
 import pytest
 from dateutil.tz import tzutc
 from deltalake import DeltaTable
+from packaging.version import Version
 from pendulum import DateTime
 from pendulum.tz.timezone import FixedTimezone, Timezone
 
-from airflow import PY39
 from airflow.models.param import Param, ParamsDict
 from airflow.serialization.serde import DATA, deserialize, serialize
 
-if PY39:
+if sys.version_info >= (3, 9):

Review Comment:
   On the one hand, we're not using whichever part of the API of 
`importlib.metadata` that changed when transitioning from provisional to stable 
(so in that sense, provisional is fine) here. On the other hand, as you 
mentioned, 3.9 is also still provisional, so there's no specific reason for 
checking for _that_. 
   
   So yeah, I prefer this check gone, but if you feel it's needed, I think you 
should check for 3.10 instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to