Taragolis commented on code in PR #37593:
URL: https://github.com/apache/airflow/pull/37593#discussion_r1497753328


##########
tests/core/test_settings.py:
##########
@@ -231,8 +231,39 @@ def 
test_uses_updated_session_timeout_config_by_default(self):
 def test_sqlite_relative_path(value, expectation):
     from airflow import settings
 
-    with patch("os.environ", {"_AIRFLOW_SKIP_DB_TESTS": "true"}), patch(
-        "airflow.settings.SQL_ALCHEMY_CONN", value
-    ), patch("airflow.settings.Session"), patch("airflow.settings.engine"):
+    with (
+        patch("os.environ", {"_AIRFLOW_SKIP_DB_TESTS": "true"}),
+        patch("airflow.settings.SQL_ALCHEMY_CONN", value),
+        patch("airflow.settings.Session"),
+        patch("airflow.settings.engine"),
+    ):

Review Comment:
   [Python 3.8 EOL](https://endoflife.date/python)
   This syntax supported by [PEP-617](https://peps.python.org/pep-0617/) and 
new [PEG](https://en.wikipedia.org/wiki/Parsing_expression_grammar) lexer which 
introduced into Python 3.9, so if for some reason user use 
legacy[LL(1)](https://en.wikipedia.org/wiki/LL_parser) Lexer I think it would 
have a syntax error here, so for [Parenthesized context 
managers](https://docs.python.org/3/whatsnew/3.10.html#parenthesized-context-managers)
 maybe we would need to wait until Python 3.9 EOL. Anyway, it is to early to 
discuss about this
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to