Dev-iL commented on code in PR #37593:
URL: https://github.com/apache/airflow/pull/37593#discussion_r1497713700


##########
tests/core/test_settings.py:
##########
@@ -231,8 +231,39 @@ def 
test_uses_updated_session_timeout_config_by_default(self):
 def test_sqlite_relative_path(value, expectation):
     from airflow import settings
 
-    with patch("os.environ", {"_AIRFLOW_SKIP_DB_TESTS": "true"}), patch(
-        "airflow.settings.SQL_ALCHEMY_CONN", value
-    ), patch("airflow.settings.Session"), patch("airflow.settings.engine"):
+    with (
+        patch("os.environ", {"_AIRFLOW_SKIP_DB_TESTS": "true"}),
+        patch("airflow.settings.SQL_ALCHEMY_CONN", value),
+        patch("airflow.settings.Session"),
+        patch("airflow.settings.engine"),
+    ):

Review Comment:
   ~Why did the build fail on this, and what's the significance of that date?~
   Ah, I see now that this is a python 3.10-specific syntax. Strange that 
neither my IDE's linter nor the hooks (black/ruff) warned about this. Is it 
because of `from __future__ import annotations`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to