ying-w commented on code in PR #38169:
URL: https://github.com/apache/airflow/pull/38169#discussion_r1527197740
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook):
If set as a sequence, the identities from the list must grant
Service Account Token Creator IAM role to the directly preceding
identity, with first
account from the list granting this role to the originating account.
+ :param impersonation_scopes: Optional list of scopes for impersonated
account. Will override scopes from connection.
Review Comment:
`impersonation` is a feature of gcp, it is theoretically possible that
another gcp service would also need this (searching for 'gcp missing scope'
gives examples of other services needing scope but not sure how many relevant
for airflow use case).
What I was trying to solve here was a narrowly scoped service account would
be able to get impersonate another account and have bigger scope. I would agree
though that the most common use case for this is bigquery accessing google
sheets. I can switch it over to bigquery library if you think that is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
