ying-w commented on code in PR #38169:
URL: https://github.com/apache/airflow/pull/38169#discussion_r1527202747


##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -190,6 +190,7 @@ class GoogleBaseHook(BaseHook):
         If set as a sequence, the identities from the list must grant
         Service Account Token Creator IAM role to the directly preceding 
identity, with first
         account from the list granting this role to the originating account.
+    :param impersonation_scopes: Optional list of scopes for impersonated 
account. Will override scopes from connection.

Review Comment:
   i'm glad that splitting providers is still be considered. just pushed the 
changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to