tatiana commented on code in PR #37725:
URL: https://github.com/apache/airflow/pull/37725#discussion_r1534099758


##########
airflow/providers/openlineage/plugins/listener.py:
##########
@@ -51,6 +57,15 @@ def __init__(self):
         self.log = logging.getLogger(__name__)
         self.extractor_manager = ExtractorManager()
         self.adapter = OpenLineageAdapter()
+        self._selective_enable = conf.getboolean("openlineage", 
"selective_enable", fallback=False)
+
+    def _is_lineage_enabled(self, obj) -> bool:

Review Comment:
   ATM we have `_is_disabled` at `openlineage/plugins/openlineage.py`, which I 
understand will enable/disable the actual listener.
   
   Would it make sense either to rename this `_is_lineage_enabled` to 
`_is_selective_lineage_enabled` or to rename the one in 
`openlineage/plugins/openlineage.py` to `_is_openlineage_listener_enabled` - so 
it's straightforward to distinguish between them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to