Lee-W commented on code in PR #38430:
URL: https://github.com/apache/airflow/pull/38430#discussion_r1538535382
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -116,17 +146,24 @@ def __init__(
"The `delegate_to` parameter has been deprecated before and
finally removed in this version"
" of Google Provider. You MUST convert it to
`impersonate_chain`"
)
- super().__init__(
- gcp_conn_id=gcp_conn_id,
- impersonation_chain=impersonation_chain,
- )
- self.use_legacy_sql = use_legacy_sql
- self.location = location
- self.priority = priority
+ super().__init__(**kwargs)
+ self.use_legacy_sql: bool = self._get_field("use_legacy_sql",
use_legacy_sql)
+ self.location: str | None = self._get_field("location", location)
+ self.priority: str = self._get_field("priority", priority)
+ self.api_resource_configs: dict =
self._get_field("api_resource_configs", api_resource_configs or {})
+ self.labels = self._get_field("labels", labels or {})
self.running_job_id: str | None = None
- self.api_resource_configs: dict = api_resource_configs or {}
- self.labels = labels
- self.credentials_path = "bigquery_hook_credentials.json"
+
+ @cached_property
+ @deprecated(
+ reason=(
+ "`BigQueryHook.credentials_path` property is deprecated and will
be removed in the future. "
+ "This property used for obtaining credentials path but no longer
in actual use. "
+ ),
+ category=AirflowProviderDeprecationWarning,
+ )
+ def credentials_path(self):
Review Comment:
```suggestion
def credentials_path(self) -> str:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
