shahar1 commented on code in PR #38430:
URL: https://github.com/apache/airflow/pull/38430#discussion_r1546734055
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -82,32 +83,113 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
This hook uses the Google Cloud connection.
- :param gcp_conn_id: The Airflow connection used for GCP credentials.
:param use_legacy_sql: This specifies whether to use legacy SQL dialect.
:param location: The location of the BigQuery resource.
:param priority: Specifies a priority for the query.
Possible values include INTERACTIVE and BATCH.
The default value is INTERACTIVE.
:param api_resource_configs: This contains params configuration applied for
Google BigQuery jobs.
- :param impersonation_chain: This is the optional service account to
Review Comment:
I restored these params, but I'd be happy if you could elaborate. In
general, when writing a docstring for a child class, should we also document
attributes from its parent? On the one hand, it sounds comfortable when
referring to the API; on the other hand, it quite violates DRY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
