potiuk commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1596612918
##########
tests/listeners/class_listener.py:
##########
@@ -47,9 +47,7 @@ def on_task_instance_success(self, previous_state,
task_instance, session):
self.state.append(TaskInstanceState.SUCCESS)
@hookimpl
- def on_task_instance_failed(
- self, previous_state, task_instance, error: None | str |
BaseException, session
- ):
+ def on_task_instance_failed(self, previous_state, task_instance, session):
Review Comment:
Ah yes - that makes sense.
But this is also interesting case - as our "tests" are now started to play
the role of "user" of airflow :) .
It means that if someone would like to write a listener to listen on error,
they cannot make 2.9 compatible code with expecting error unless they are doing
similar if . I am fine with it, but I think we should describe it in listener
documentation that if you - for example - want to write a plugin that works for
both Airlfow 2.9 and 2.10, your listener should support both variants (or just
the 2.9 one if you are not interested in receieving the error).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
