potiuk commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1596664607
##########
tests/providers/amazon/aws/executors/batch/test_batch_executor.py:
##########
@@ -626,7 +626,7 @@ def _unset_conf():
def teardown_method(self) -> None:
self._unset_conf()
- def test_validate_config_defaults(self):
+ def test_validate_config_defaults(self,
require_running_tests_from_sources):
Review Comment:
Hmm @o-nikolas I think the recent changes **broke** the current tests with
executor simply. This might mean for example that current executor
implementation (in main) will not work with Airflow 2.9 - might be accidental
change, but with this one, our test suite works essentiallly as "client" for
diffferent airflow versions, so we should be able use the tests to detect such
cases (And correct the test to do the right thing - as expected from those who
write the executors). Would love if you could take a look at this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
