potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597505127
########## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ########## @@ -367,6 +368,7 @@ def test_stopped_tasks(self): class TestAwsEcsExecutor: """Tests the AWS ECS Executor.""" + @pytest.mark.skipif(not AIRFLOW_V_2_10_PLUS, reason="Test requires Airflow 2.10+") Review Comment: Hey @o-nikolas -> I skipped this failing tests for Airlfow < 2.10 - indeed it looks like calling `change_state` has been added in https://github.com/apache/airflow/pull/39212 and is only going to happen in Airflow 2.10+ . I am not sure what effect it has on AwsEcsExecutor- whether it will have any side effect when runnning on Airflow 2.9 - I guess the executor is still in "experimental" phase, but in case this change is somewhat braking for the Executor, it would be wise to add a runtime check for the upcoming Amazon provider's executor to fail explicitly for Airflow < 2.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org