potiuk commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1597725944


##########
tests/providers/openlineage/plugins/test_openlineage.py:
##########
@@ -131,7 +131,7 @@ def teardown_method(self):
             ),
         ],
     )
-    def test_plugin_disablements(self, mocks, expected):
+    def test_plugin_disablements(self, mocks, expected, 
require_running_tests_from_sources):

Review Comment:
   OK. I think I fixed it by making the imports local to the tests.  When 
airflow is installed from package, just importing airflow package will 
initialize the plugins **before** patching done by the test. But by moving 
airflow imports to inside setup/teardown methods, we delay plugin 
initializiation to the setup method which is is run after patching of the os 
environment is done for the test. That seems to fix the problem. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to