kisssam commented on PR #39568:
URL: https://github.com/apache/airflow/pull/39568#issuecomment-2106273245
> > Setting the regex as `LABEL_REGEX = re.compile(r"^[\w-]{0,63}$")` since
the documentation [1] indicates that label values can start with numbers,
hyphen and underscore as well.
> > ```
> > Values can be empty, and have a maximum length of 63 characters.
> >
> > ... values can contain only lowercase letters, numeric characters,
underscores, and dashes
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > [1] https://cloud.google.com/bigquery/docs/labels-intro#requirements
>
> What about `Keys must start with a lowercase letter or international
character.`?
As mentioned in [this
line](https://github.com/apache/airflow/blob/4299dd974fe9881c7c8db37159af1184ba502933/airflow/providers/google/cloud/operators/bigquery.py#L2884),
as part of the label addition logic, the label keys used will be static, i.e.
`airflow-dag` and `airflow-task` - hence the validation is only needed for the
label values being passed, which the above validation regex will take care of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
