kisssam commented on PR #39568:
URL: https://github.com/apache/airflow/pull/39568#issuecomment-2107122252

   On testing on a Cloud Composer environment with 
`apache-airflow-providers-google==10.18.0rc2`, all other test cases except the 
scenario where a task starts with a hyphen fails. 
   
   However, this appears to be because Airflow DAG names and task IDs do not 
work well if they start with hyphen as seen in the below example:
   
   
![dags_starting_with_hyphen_not_parseable](https://github.com/apache/airflow/assets/88154748/2e1cd2e0-834d-4468-b7d5-c291043cbacc)
   
   However, I can confirm as seen below that BigQuery labels support labels 
starting with hyphens as [mentioned 
above](https://github.com/apache/airflow/pull/39568#issuecomment-2106273245).
   
   ![bq show output for job with labels starting with 
hyphen](https://github.com/apache/airflow/assets/88154748/e302e2c9-d9f9-4ea1-ba65-9937744b8034)
   
   
   Hence, can you please let me know if this makes sense to remove the [test 
case for the task starting with a 
hyphen](https://github.com/kisssam/airflow/blob/4299dd974fe9881c7c8db37159af1184ba502933/tests/providers/google/cloud/operators/test_bigquery.py#L1961-L1978)
 since although Airflow allows to create a DAG/task starting with hyphen, it is 
not going to work as expected ? @eladkal 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to