RNHTTR commented on code in PR #39603:
URL: https://github.com/apache/airflow/pull/39603#discussion_r1600051288
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -3776,6 +3776,11 @@ def test_create_dag_runs_datasets(self, session,
dag_maker):
dataset1 = Dataset(uri="ds1")
dataset2 = Dataset(uri="ds2")
+ # Create DAG before the arrival of dataset events.
Review Comment:
Should this be part of its own, new test?
`test_new_dagrun_ignores_old_datasets` or similar?
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -3811,20 +3816,40 @@ def test_create_dag_runs_datasets(self, session,
dag_maker):
)
session.add(event2)
+ # Create a third event, creation time is more recent, but data
interval is even older
Review Comment:
Given that this is reproducible with a single, previous DAG run having a
dataset event, shouldn't the test only require 3 total DAG runs?
- One DAG run from the original DAG (let's call this Run A)
- One more DAG run (Run B) after the new DAG is introduced, which triggers
the new DAG's DAG run which should only have dataset info from Run B.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
