tosheer commented on code in PR #39603:
URL: https://github.com/apache/airflow/pull/39603#discussion_r1602715372


##########
tests/jobs/test_scheduler_job.py:
##########
@@ -3776,6 +3776,11 @@ def test_create_dag_runs_datasets(self, session, 
dag_maker):
         dataset1 = Dataset(uri="ds1")
         dataset2 = Dataset(uri="ds2")
 
+        # Create DAG before the arrival of dataset events.

Review Comment:
   @RNHTTR I've added a new unit test. Please review it and let me know if it 
needs any adjustments. 
   
   Unit test is checking newly added Dag should just get the Dataset arrived 
after it was created(event3) and not the dataset events(event 1 and event2)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to