amoghrajesh commented on code in PR #39789:
URL: https://github.com/apache/airflow/pull/39789#discussion_r1612718569
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -611,16 +611,7 @@ def execute_sync(self, context: Context):
mode=ExecutionMode.SYNC,
)
- if self.get_logs:
- self.pod_manager.fetch_requested_container_logs(
- pod=self.pod,
- containers=self.container_logs,
- follow_logs=True,
- )
- if not self.get_logs or (
- self.container_logs is not True and self.base_container_name
not in self.container_logs
- ):
- self.await_container_completion(pod=self.pod,
container_name=self.base_container_name)
+ self.await_container_completion(pod=self.pod)
Review Comment:
Lets not modify the signature here. We were calling a function based on
flag, avoid a call if not set.
Now we enter irrespective of the flag here. Lets keep it as it was earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
