paolo-moriello commented on code in PR #39789:
URL: https://github.com/apache/airflow/pull/39789#discussion_r1613103878


##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -611,16 +611,7 @@ def execute_sync(self, context: Context):
                     mode=ExecutionMode.SYNC,
                 )
 
-            if self.get_logs:
-                self.pod_manager.fetch_requested_container_logs(
-                    pod=self.pod,
-                    containers=self.container_logs,
-                    follow_logs=True,
-                )
-            if not self.get_logs or (
-                self.container_logs is not True and self.base_container_name 
not in self.container_logs
-            ):
-                self.await_container_completion(pod=self.pod, 
container_name=self.base_container_name)
+            self.await_container_completion(pod=self.pod)

Review Comment:
   @amoghrajesh I've updated the function to make the separation more clear



##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -611,16 +611,7 @@ def execute_sync(self, context: Context):
                     mode=ExecutionMode.SYNC,
                 )
 
-            if self.get_logs:
-                self.pod_manager.fetch_requested_container_logs(
-                    pod=self.pod,
-                    containers=self.container_logs,
-                    follow_logs=True,
-                )
-            if not self.get_logs or (
-                self.container_logs is not True and self.base_container_name 
not in self.container_logs
-            ):
-                self.await_container_completion(pod=self.pod, 
container_name=self.base_container_name)
+            self.await_container_completion(pod=self.pod)

Review Comment:
   @amoghrajesh I've updated the function to make the distinction more clear



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to