dstandish commented on code in PR #39585: URL: https://github.com/apache/airflow/pull/39585#discussion_r1623810689
########## airflow/models/taskinstance.py: ########## @@ -1615,8 +1632,10 @@ def _defer_task( ti.trigger_timeout = ti.start_date + execution_timeout if ti.test_mode: _add_log(event=ti.state, task_instance=ti, session=session) - session.merge(ti) - session.commit() + + if exception is not None: Review Comment: like... it seems you need to commit here always, since you always mutate TI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org