jrderuiter commented on code in PR #41639:
URL: https://github.com/apache/airflow/pull/41639#discussion_r1738426848
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -374,6 +377,95 @@ async def _a_get_aad_token(self, resource: str) -> str:
return jsn["access_token"]
+ def _get_aad_token_for_workload_identity(self, resource: str) -> str:
Review Comment:
In principle getting a token in this manner isn't restricted to workload
identity perse. For example, using the `DefaultAzureCredential` you can support
any of the authentication options listed here:
https://learn.microsoft.com/en-us/dotnet/azure/sdk/authentication/credential-chains?tabs=dac#defaultazurecredential-overview.
Would it make sense to rename this method to reflect this and maybe use an
options such as `use_azure_default_credential` instead?
For local development this more general option would also be awesome, as it
(for example) allows you to use your personal Entra ID together with the Azure
CLI to authenticate to a Databricks cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
