jrderuiter commented on code in PR #41639:
URL: https://github.com/apache/airflow/pull/41639#discussion_r1745681899
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -502,6 +597,10 @@ async def _a_get_token(self, raise_error: bool = False) ->
str | None:
self.log.debug("Using AAD Token for managed identity.")
await self._a_check_azure_metadata_service()
return await self._a_get_aad_token(DEFAULT_DATABRICKS_SCOPE)
+ elif
self.databricks_conn.extra_dejson.get(DEFAULT_AZURE_CREDENTIAL_SETTING_KEY,
False):
+ self.log.debug("Using AzureDefaultCredentialy for authentication.")
Review Comment:
Small typo in the log: `AzureDefaultCredentialy` ->
`AzureDefaultCredential`.
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -63,6 +64,8 @@
DEFAULT_DATABRICKS_SCOPE = "2ff814a6-3304-4ab8-85cb-cd0e6f879c1d"
OIDC_TOKEN_SERVICE_URL = "{}/oidc/v1/token"
+DEFAULT_AZURE_CREDENTIAL_SETTING_KEY = "use_default_azure_credential"
Review Comment:
This key should also be added to the `extra_parameters` list in line 89 I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
