potiuk commented on code in PR #42081: URL: https://github.com/apache/airflow/pull/42081#discussion_r1818934968
########## providers/src/airflow/providers/amazon/aws/operators/appflow.py: ########## @@ -21,12 +21,16 @@ from typing import TYPE_CHECKING, cast from airflow.exceptions import AirflowException -from airflow.operators.python import ShortCircuitOperator from airflow.providers.amazon.aws.hooks.appflow import AppflowHook from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator from airflow.providers.amazon.aws.utils import datetime_to_epoch_ms from airflow.providers.amazon.aws.utils.mixins import AwsBaseHookMixin, AwsHookParams, aws_template_fields +try: + from airflow.providers.standard.operators.python import ShortCircuitOperator +except ImportError: + from airflow.operators.python import ShortCircuitOperator # type: ignore[no-redef,attr-defined] Review Comment: Actually, we will be able to drop that at the moment we release standard provider. We do not need to wait for Airflow 3 to happen. The idea is that standard provider will be installable - as any other provider in Airflow 2 (with same min-airflow-versionas all the other providers). And it does not even have to be pre-installed in Airflow 2, it's enough that the providers that import standard-provider's imports - add the standard provider as a dependency. That's enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
