potiuk commented on code in PR #42081: URL: https://github.com/apache/airflow/pull/42081#discussion_r1818980029
########## providers/src/airflow/providers/amazon/aws/operators/appflow.py: ########## @@ -21,12 +21,16 @@ from typing import TYPE_CHECKING, cast from airflow.exceptions import AirflowException -from airflow.operators.python import ShortCircuitOperator from airflow.providers.amazon.aws.hooks.appflow import AppflowHook from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator from airflow.providers.amazon.aws.utils import datetime_to_epoch_ms from airflow.providers.amazon.aws.utils.mixins import AwsBaseHookMixin, AwsHookParams, aws_template_fields +try: + from airflow.providers.standard.operators.python import ShortCircuitOperator +except ImportError: + from airflow.operators.python import ShortCircuitOperator # type: ignore[no-redef,attr-defined] Review Comment: > That depends if aws provider will have min version of Airflow 3 or not (or if standard provider will be compatible with older versions) No - standard provider is supposed to be compatible with Airlfow 2 and you won't need min-airflow-version 3 to use it. It's entirely possible (and desired) for standard provider to have min-airlfow-version 2.8 or 2.9 or 2.10 (depending when we release it), and it is completely no problem for future AWS provider to import from it even when min-airflow-version for it will be 2.8, 2,9 or 2.10 respectively. This is all entirely doable and standard provider release was going to be done way before Airflow 3 to suppport that scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
