rawwar commented on code in PR #44121:
URL: https://github.com/apache/airflow/pull/44121#discussion_r1845913045
##########
airflow/api_fastapi/core_api/routes/public/pools.py:
##########
@@ -167,15 +168,57 @@ def patch_pool(
@pools_router.post(
"/",
status_code=status.HTTP_201_CREATED,
- responses=create_openapi_http_exception_doc([status.HTTP_401_UNAUTHORIZED,
status.HTTP_403_FORBIDDEN]),
+ responses=create_openapi_http_exception_doc(
+ [status.HTTP_401_UNAUTHORIZED, status.HTTP_403_FORBIDDEN,
status.HTTP_409_CONFLICT]
+ ),
)
def post_pool(
post_body: PoolPostBody,
session: Annotated[Session, Depends(get_session)],
) -> PoolResponse:
"""Create a Pool."""
+ pool = session.scalar(select(Pool).where(Pool.pool == post_body.pool))
Review Comment:
```suggestion
pool = session.scalar(select(Pool).where(Pool.pool == body.pool))
```
##########
airflow/api_fastapi/core_api/routes/public/pools.py:
##########
@@ -167,15 +168,57 @@ def patch_pool(
@pools_router.post(
"/",
status_code=status.HTTP_201_CREATED,
- responses=create_openapi_http_exception_doc([status.HTTP_401_UNAUTHORIZED,
status.HTTP_403_FORBIDDEN]),
+ responses=create_openapi_http_exception_doc(
+ [status.HTTP_401_UNAUTHORIZED, status.HTTP_403_FORBIDDEN,
status.HTTP_409_CONFLICT]
+ ),
)
def post_pool(
post_body: PoolPostBody,
session: Annotated[Session, Depends(get_session)],
) -> PoolResponse:
"""Create a Pool."""
+ pool = session.scalar(select(Pool).where(Pool.pool == post_body.pool))
Review Comment:
```suggestion
pool = session.scalar(select(Pool).where(Pool.pool == body.pool))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
