jason810496 commented on code in PR #44121:
URL: https://github.com/apache/airflow/pull/44121#discussion_r1846154421
##########
airflow/api_fastapi/core_api/routes/public/pools.py:
##########
@@ -167,15 +168,57 @@ def patch_pool(
@pools_router.post(
"/",
status_code=status.HTTP_201_CREATED,
- responses=create_openapi_http_exception_doc([status.HTTP_401_UNAUTHORIZED,
status.HTTP_403_FORBIDDEN]),
+ responses=create_openapi_http_exception_doc(
+ [status.HTTP_401_UNAUTHORIZED, status.HTTP_403_FORBIDDEN,
status.HTTP_409_CONFLICT]
+ ),
)
def post_pool(
post_body: PoolPostBody,
session: Annotated[Session, Depends(get_session)],
) -> PoolResponse:
"""Create a Pool."""
+ pool = session.scalar(select(Pool).where(Pool.pool == post_body.pool))
+ if pool is not None:
+ raise HTTPException(status.HTTP_409_CONFLICT, f"Pool with name:
`{post_body.pool}` already exists")
Review Comment:
I noticed that the API handling the creation of connections includes an
additional database query to check for duplicates. Reference:
https://github.com/apache/airflow/blob/main/airflow/api_fastapi/core_api/routes/public/connections.py#L136-L138.
Should we adopt a consistent approach across the codebase by either relying
on handling database insert exceptions or using additional database queries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
