amoghrajesh commented on code in PR #44469:
URL: https://github.com/apache/airflow/pull/44469#discussion_r1863704801
##########
dev/breeze/src/airflow_breeze/utils/github.py:
##########
@@ -54,6 +54,11 @@ def download_file_from_github(tag: str, path: str,
output_file: Path, timeout: i
if not get_dry_run():
try:
response = requests.get(url, timeout=timeout)
+ if response.status_code == 403:
+ get_console().print(
+ f"[error]The {url} is not accessible.This may be caused by
network issues or VPN settings"
Review Comment:
Its actually pretty useless to print `response.content` - it deviates
entirely from the actual error
##########
dev/breeze/src/airflow_breeze/utils/github.py:
##########
@@ -54,6 +54,11 @@ def download_file_from_github(tag: str, path: str,
output_file: Path, timeout: i
if not get_dry_run():
try:
response = requests.get(url, timeout=timeout)
+ if response.status_code == 403:
+ get_console().print(
+ f"[error]The {url} is not accessible.This may be caused by
network issues or VPN settings"
Review Comment:
Throttle limit, yes. Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
