vincbeck commented on code in PR #44469:
URL: https://github.com/apache/airflow/pull/44469#discussion_r1863810134
##########
dev/breeze/src/airflow_breeze/utils/github.py:
##########
@@ -54,6 +54,13 @@ def download_file_from_github(tag: str, path: str,
output_file: Path, timeout: i
if not get_dry_run():
try:
response = requests.get(url, timeout=timeout)
+ if response.status_code == 403:
+ get_console().print(
+ f"[error]The {url} is not accessible.This may be caused by
either of:\n"
+ f" 1. network issues or VPN settings\n"
+ f" 2. Github rate limiting limit"
Review Comment:
The double limit looks weird (nota. native english speaker here so I might
be wrong)
```suggestion
f" 2. Github rate limit"
```
##########
dev/breeze/src/airflow_breeze/utils/github.py:
##########
@@ -54,6 +54,13 @@ def download_file_from_github(tag: str, path: str,
output_file: Path, timeout: i
if not get_dry_run():
try:
response = requests.get(url, timeout=timeout)
+ if response.status_code == 403:
+ get_console().print(
+ f"[error]The {url} is not accessible.This may be caused by
either of:\n"
+ f" 1. network issues or VPN settings\n"
+ f" 2. Github rate limiting limit"
Review Comment:
The double limit looks weird (not a native english speaker here so I might
be wrong)
```suggestion
f" 2. Github rate limit"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
